[Webkit-unassigned] [Bug 192712] clang-tidy: Fix unnecessary copy of objects for operator==() methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 14 13:24:52 PST 2018


--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
I also ran this terrible hack of a command to try to find other operator==() methods that weren't using const references:

$ grep -r 'bool operator==(const' Source | egrep -v '(&[ \),]| &[a-zA-Z])'

The only interesting things it found were:

Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:        bool operator==(const InterferenceEdge other) const

Source/JavaScriptCore/runtime/JSCJSValue.h:inline bool operator==(const JSValue a, const JSCell* b) { return a == JSValue(b); }
Source/JavaScriptCore/runtime/JSCJSValue.h:inline bool operator==(const JSCell* a, const JSValue b) { return JSValue(a) == b; }

Source/WTF/wtf/text/StringView.h:inline bool operator==(const char* a, StringView b) { return equal(b, a); }

I'll fix AirAllocateRegistersByGraphColoring.cpp in this patch, but handle the others using separate patches.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181214/957d8ba9/attachment-0001.html>

More information about the webkit-unassigned mailing list