[Webkit-unassigned] [Bug 192391] Use hash in Unified Sources filenames instead of ascending integers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 16:01:47 PST 2018


--- Comment #14 from Carlos Eduardo Ramalho <cadubentzen at gmail.com> ---
(In reply to Fujii Hironori from comment #13)
> IIUC, this change leaves stale generated unified sources and its object
> files.
> IIUC, source files are grouped by directories. What about using filenames
> UnifiedSource-{hash-of-dir-name}-{seq-num-within-the-dir}.cpp?

Well noted! I'll try to do as per you recommendation and see.

Although in this new way it'll be sub-optimal compared to the original strategy because we'll have a sequence of unified sources for a given folder which may be all changed after adding a new source. But it should still speed up recompilation a lot compared to the worst case scenario as described in the example.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181213/574c0d86/attachment.html>

More information about the webkit-unassigned mailing list