[Webkit-unassigned] [Bug 192622] [GTK][WPE] Fix forwarding webkit socket to flatpak sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192622

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 357120
  --> https://bugs.webkit.org/attachment.cgi?id=357120
[GTK][WPE] Fix forwarding webkit socket to flatpak sandbox

View in context: https://bugs.webkit.org/attachment.cgi?id=357120&action=review

> Source/WebKit/ChangeLog:7
> +

Pleas explain here what the patch does and it fixes.

> Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.cpp:32
>  

Remove this empty line.

> Source/WebKit/UIProcess/Launcher/glib/FlatpakLauncher.cpp:37
> +GRefPtr<GSubprocess> flatpakSpawn(GSubprocessLauncher* launcher, const WebKit::ProcessLauncher::LaunchOptions& launchOptions, char** argv, GError **error, int webkitSocket)

I would add the parameter before the error one, which is typically the last one. I would use childProcessSocket or something like that instead of webkitsocket.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181212/ee28572e/attachment.html>