[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 11:52:34 PST 2018


--- Comment #41 from Chris Dumez <cdumez at apple.com> ---
(In reply to Alex Christensen from comment #40)
> Comment on attachment 357066 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357066&action=review
> > Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:261
> > +static ResourceResponse simulatedRedirectResponse(const URL& fromURL, const URL& toURL)
> Is there a reason we are not removing synthesizeRedirectResponseIfNecessary
> in favor of this?

synthesizeRedirectResponseIfNecessary has this:
    if ([[[newRequest URL] scheme] isEqualToString:[[currentRequest URL] scheme]] && !schemeWasUpgradedDueToDynamicHSTS(newRequest))
        return nil;

So We'd have to move the check out to the caller but otherwise why not. Less duplication.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181211/bc2391b9/attachment.html>

More information about the webkit-unassigned mailing list