[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 10:24:48 PST 2018


Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
 Attachment #357009|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #37 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357009
  --> https://bugs.webkit.org/attachment.cgi?id=357009

View in context: https://bugs.webkit.org/attachment.cgi?id=357009&action=review

r=me with a couple of nits. We should also definitely fix GTK build.

> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:46
> +    enum class LoadType { MainFrame, Other };

enum class LoadType : bool { MainFrame, Other };

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:190
> +                    willSendRedirectedRequest(WTFMove(triplet.request), WTFMove(triplet.redirectRequest), WTFMove(triplet.redirectResponse));

You may need this-> here to to fix GTK build.

> Source/WebKit/NetworkProcess/PingLoad.cpp:65
> +                this->loadRequest(WTFMove(triplet.redirectRequest));

This think this should be an ASSERT_NOT_REACHED(). We should never be simulating redirects for Ping Loads.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181211/cbf18a1c/attachment-0001.html>

More information about the webkit-unassigned mailing list