[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 14:49:54 PST 2018


--- Comment #32 from Vivek Seth <v_seth at apple.com> ---
Comment on attachment 356978
  --> https://bugs.webkit.org/attachment.cgi?id=356978

View in context: https://bugs.webkit.org/attachment.cgi?id=356978&action=review

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:157
>> +            handler(RedirectionTriplet { WTFMove(request), WTFMove(triplet.redirectRequest), WTFMove(redirectResponse) });
> You should be able to write it as:
> handler(WTFMove(triplet))

The reason I didn't do that is because `triplet.redirectResponse` != `redirectResponse`. As we discussed this morning we may need to modify `redirectResponse` if a simulated redirect needs to happen.

>>> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:209
>>> +        return;
>> Why don't we want to upgrade sub resource requests?
> This has been discussed, we have no guarantee that this would work. Only main frame URLs were tested.

We only upgrade if we know that all sub-resource requests will also be HTTPS

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181210/8199f7b8/attachment-0001.html>

More information about the webkit-unassigned mailing list