[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192375

--- Comment #30 from Chris Dumez <cdumez at apple.com> ---
(In reply to Alex Christensen from comment #29)
> Comment on attachment 356978 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=356978&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:209
> > +    if (m_requestLoadType != LoadType::MainFrame)
> > +        return;
> 
> Why don't we want to upgrade sub resource requests?

This has been discussed, we have no guarantee that this would work. Only main frame URLs were tested.

> 
> > Source/WebKit/NetworkProcess/NetworkLoadChecker.h:64
> > +    void check(WebCore::ResourceRequest&&, WebCore::ContentSecurityPolicyClient*, ValidationHandler&&);
> 
> This is a bad name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181210/8e34f600/attachment.html>