[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192375

--- Comment #24 from youenn fablet <youennf at gmail.com> ---
The idea is to have NetworkLoadChecker::check take a completion handler that takes a new parameter.
ValidationHandler would become a private declaration for NetworkLoadChecker internal use.
That will require to change ping load but that is ok (hopefully at some point, we will kill it anyway).

As I suggested when we discussed last week, I like std::optional<ResourceResponse>&&.
ResourceResponse&& is sort of ok as well.

As of whether you handle correctly or not the redirection case, I think it is sort of ok right now: the new resource request URL should be upgraded and that is what probably  count. Of course testing should ensure that.

It is true that the redirect response will not match the new resource request URL.
Maybe we should update the redirect response location header to match the new resource request URL, for extra safety.
But this is an existing issue with the current code. I would tackle this as a follow-up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181210/f71f1bf2/attachment-0001.html>