[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 16:17:57 PST 2018


--- Comment #19 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 356844
  --> https://bugs.webkit.org/attachment.cgi?id=356844

View in context: https://bugs.webkit.org/attachment.cgi?id=356844&action=review

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:226
> +    auto continueCheckingRequestOrAllowSimulatedRedirect = [this](ResourceRequest&& originalRequest, ResourceRequest&& currentRequest, ValidationHandler&& handler) {

How about making the lambda a method of NetworkLoadChecker.
This remove the need to capture this (as who knows if 'this' is valid).

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:238
> +        RELEASE_LOG_IF_ALLOWED("checkRequest - Upgrade URL from HTTP to HTTPS");

I would tend to make applyHTTPSUpgradeIfNeeded return void.
And put the RELEASE_LOG_IF_ALLOWED in applyHTTPSUpgradeIfNeeded.
Depending on applyHTTPSUpgradeIfNeeded implementation, the ASSERT might be useful or not.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:126
> +            m_networkLoadChecker->setRequestLoadType(NetworkLoadChecker::LoadType::MainFrame);

I think we should set request load type in NetworkLoadChecker constructor since it stays the same for the lifetime of m_networkLoadChecker .
This will remove the need for setRequestLoadType.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:216
> +                m_isWaitingContinueWillSendRequestForCachedRedirect = true;

I think this is ok to keep the name m_isWaitingContinueWillSendRequestForCachedRedirect even though it is not exactly correct anymore.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181208/9fb01f3a/attachment.html>

More information about the webkit-unassigned mailing list