[Webkit-unassigned] [Bug 192006] Record right offset with aligned wide instructions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192006

Yusuke Suzuki <yusukesuzuki at slowstart.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356798|review?                     |review+
              Flags|                            |

--- Comment #9 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 356798
  --> https://bugs.webkit.org/attachment.cgi?id=356798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356798&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2787
> +    auto inst = m_lastInstruction;
> +    m_staticPropertyAnalyzer.createThis(dst, WTFMove(inst));

By changing the signature of `createThis` from `void createThis(RegisterID* dst, InstructionStream::MutableRef&& instructionRef);` to `void createThis(RegisterID* dst, InstructionStream::MutableRef instructionRef);`,
we do not need `auto inst = m_lastInstruction;` and `WTFMove` here.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2899
> +    auto inst = m_lastInstruction;
> +    m_staticPropertyAnalyzer.newObject(dst, WTFMove(inst));
> +

Ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181207/0293ecfe/attachment.html>