[Webkit-unassigned] [Bug 191997] REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191997

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
(In reply to Carlos Eduardo Ramalho from comment #4)
> (In reply to Michael Catanzaro from comment #1)
> > Another option would be to add explicit dependencies at the CMake level if
> > async scrolling really is supposed to depend on coordinated graphics, but
> > they would have to be duplicated in both OptionsGTK.cmake and
> > OptionsWPE.cmake because ENABLE_OPENGL is not a cross-platform option:
> > 
> > WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_OPENGL)
> 
> Did that in OptionsGTK.cmake but it is not need for WPE because
> 1) there's no ENABLE_OPENGL for WPE
> 2) ENABLE_ASYNC_SCROLLING is always on there explicitly

JFTR, this seems like a reasonably good approach to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181206/6555793b/attachment.html>