[Webkit-unassigned] [Bug 192375] HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192375

--- Comment #7 from Vivek Seth <v_seth at apple.com> ---
Comment on attachment 356651
  --> https://bugs.webkit.org/attachment.cgi?id=356651
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356651&action=review

Fixed some of the easy comments. I will look at the harder ones now.

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:229
>> +    // Only upgade if there is a way to notify parent.
> 
> s/upgade/upgrade

fixed this

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:230
>> +    if (m_didUpdateRequestURL) {
> 
> I would do this if check in applyHTTPSUpgradeIfNeeded.
> 
> The name m_didUpdateRequestURL seems like a boolean while it is a callback.
> It might be good to change the name to m_didUpdateRequestURLCallback

I agree, fixed this.

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:250
>> +    processContentExtensionRulesForLoad(WTFMove(request), [this, handler = WTFMove(handler), originalRequest](auto result) mutable {
> 
> originalRequest = WTFMove(originalRequest)

OK

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:216
>> +    WTF::Function<void(void)> m_didSendSimulatedRedirectCallback;
> 
> s/void(void)/void()/

Fixed this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181205/a004e21a/attachment.html>