[Webkit-unassigned] [Bug 191155] SimulatedInputDispatcher::transitionInputSourceToState() can reuse a moved-from completion handler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 11:39:34 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=191155

--- Comment #5 from Brian Burg <bburg at apple.com> ---
Hi Zan, I looked into this some more. The code does indeed move the completion and operate in a loop. This doesn't affect safaridriver because it sends a differently formatted interaction sequence. safaridriver's sequence makes a separate state for each virtual key change. Thus, the problematic loop only ever executes once.

I'd prefer to add a return in the loop so it can't possibly simulate >1 action. Then, fix webkitdriver to emit more intermediate events.

It might be possible to use an accumulator-like thing so that such inputs are acceptable input for SimulatedInputDispatcher, but this code is already really async and it will be hard to get it right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181205/913f9752/attachment.html>


More information about the webkit-unassigned mailing list