[Webkit-unassigned] [Bug 192409] New: webkitpy: Ignore case when comparing device types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 10:26:33 PST 2018


            Bug ID: 192409
           Summary: webkitpy: Ignore case when comparing device types
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jbedard at apple.com
                CC: lforschler at apple.com

When discussing <https://bugs.webkit.org/show_bug.cgi?id=192161>, which lays the groundwork for <https://bugs.webkit.org/show_bug.cgi?id=192162>, Lucas Forschler pointed out to me that while devices types are always capitalized, platforms are never capitalized. This will no doubt cause confusion when device types are embedded into expected results. To remedy this confusion, we can make the DeviceType class ignore the case of the contained strings when comparing. This means a DeviceType constructed with a lowercase string would match the DeviceType coming from simctl (which will have some letters capitalized)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181205/552f1baa/attachment.html>

More information about the webkit-unassigned mailing list