[Webkit-unassigned] [Bug 192391] Use hash in Unified Sources filenames instead of ascending integers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 09:08:28 PST 2018


--- Comment #5 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 356572
  --> https://bugs.webkit.org/attachment.cgi?id=356572
Test the bots

View in context: https://bugs.webkit.org/attachment.cgi?id=356572&action=review

> Source/WTF/Scripts/generate-unified-source-bundles.rb:207
> +        digest = Digest::SHA1.hexdigest(@currentBundleText)[0..12]

Can we still use the number too, preferably before the hash for sorting reasons? I like having the number as it helps me know how far into the build I am. CMake doesn't really track the completion percentage all that well.

So it would be "UnifiedSource-#{number}-#{digest}.#{extension}".

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181205/f8a41c24/attachment.html>

More information about the webkit-unassigned mailing list