[Webkit-unassigned] [Bug 191926] [EME][ClearKey] Add layout test for dynamic change of key and video resolution

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191926

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #355727|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 355727
  --> https://bugs.webkit.org/attachment.cgi?id=355727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355727&action=review

> LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse-multikey.html:26
> +            else {
> +                if (video.currentTime >= 4) {

This can be an else if

> LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse-multikey.html:27
> +                if (video.currentTime >= 4) {
> +                    testExpected("video.currentTime", 4, ">=")

No strong opinion on this, just looks a bit weird to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181203/274225a1/attachment.html>