[Webkit-unassigned] [Bug 189063] REGRESSION(r235408): GTK bots exiting early
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 31 13:01:39 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=189063
--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
(In reply to Michael Catanzaro from comment #9)
> (In reply to Simon Fraser (smfr) from comment #8)
> > Happy to help out if we can be on irc at the same time.
>
> Thanks... it's been a busy week and next week will be too, so probably not
> anytime soon unfortunately.
>
> > I did spot one unrelated bug in the commit, in
> > Tools/DumpRenderTree/win/DumpRenderTree.cpp:
> >
> > // DumpRenderTree does not support checking for abandonded documents.
> > if (!strcmp("#CHECK FOR ABANDONED DOCUMENTS", command)) {
> >
> > I noticed that "abandonded" was misspelled. Then I noticed that the command
> > here is different than everywhere else. Should probably be:
> >
> > // DumpRenderTree does not support checking for world leaks.
> > if (!strcmp("#CHECK FOR WORLD LEAKS", command)) {
>
> Don't forget about this. ^
Fixed in r235408.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180831/dd3cd1c7/attachment.html>
More information about the webkit-unassigned
mailing list