[Webkit-unassigned] [Bug 188996] Add IGNORE_WARNING_.* macros

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 02:46:59 PDT 2018


--- Comment #30 from Guillaume Emont <guijemont at igalia.com> ---
(In reply to mitz from comment #29)
> (In reply to Guillaume Emont from comment #27)
> > In looking at the most common ignored warnings, -Wunknown-pragmas is high on
> > the list, though almost all of its uses were introduced in r220577. It's
> > unclear to me whether this could be replaced by using a __has_warning()
> > check or there is another reason to ignore -Wunknown-pragmas here.
> > Adding Dan Bernstein in Cc in the hope that he can enlighten me.
> I don’t know whether __has_warning() could be used instead, which tells you
> that I didn’t consider it at the time, simply because I didn’t think to do
> so. If it works for other warning-ignoring in our codebase I don’t see a
> reason why it wouldn’t work for unguarded-availability-new.

Ok, thanks for the information!

I couldn't figure out how to check that easily for older versions, but __has_warning() is supported from at least clang 3.1:

It's not clear to me what is the earliest version of clang we support, but I imagine it is later than that, meaning we can safely rely on __has_warning() and don't need -Wunkown-pragmas for that case.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180831/6ee1cfd2/attachment.html>

More information about the webkit-unassigned mailing list