[Webkit-unassigned] [Bug 186714] [Datalist][iOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186714

--- Comment #16 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 348221
  --> https://bugs.webkit.org/attachment.cgi?id=348221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348221&action=review

Other than the `information.activationType` above, this looks okay to me.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:122
> +void WebDataListSuggestionsDropdownIOS::didSelectOption(String& selectedOption)

Nit - this should be a const String&

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180830/d562f19c/attachment.html>