[Webkit-unassigned] [Bug 186714] [Datalist][iOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186714

--- Comment #15 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 348221
  --> https://bugs.webkit.org/attachment.cgi?id=348221
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348221&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:384
> +        [_customInputView performSelector:@selector(endEditing)];

I think we generally prefer to cast to the relevant ObjC protocol or type and call the selector (-endEditing) directly, instead of using -performSelector:.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:108
> +    [m_suggestionsControl showSuggestionsDropdown:this activationType:information.activationType];

Hm...but we already WTFMove'd our information above! Perhaps you meant to save the value of information.activationType in a temporary before creating m_suggestionsControl?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180830/ab7866d8/attachment.html>