[Webkit-unassigned] [Bug 189078] [JSC] Build broken after r234975 on s390x, ppc64le, armv7hl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189078

--- Comment #1 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
(In reply to Tomas Popela from comment #0)
> After r234975 the build fails on s390x, ppc64le, armv7hl with:
> 
> [ 48%] Building CXX object
> Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/
> JavaScriptCore/unified-sources/UnifiedSource68.cpp.o
> cd
> /builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/Source/
> JavaScriptCore && /usr/bin/c++  -DBUILDING_GTK__=1 -DBUILDING_JavaScriptCore
> -DBUILDING_WITH_CMAKE=1 -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\"
> -DHAVE_CONFIG_H=1 -DJSC_COMPILATION -DJSC_GLIB_API_ENABLED
> -DJavaScriptCore_EXPORTS -DSTATICALLY_LINKED_WITH_WTF
> -DWEBKITGTK_API_VERSION_STRING=\"4.0\"
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/ForwardingHeaders
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/API
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/assembler
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/b3
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/b3/air
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/bindings
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/builtins
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/bytecode
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/bytecompiler
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/dfg
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/disassembler
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/disassembler/
> ARM64
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/disassembler/
> udis86
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/domjit
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/ftl
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/debugger
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/inspector
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/inspector/
> agents
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/inspector/
> augmentable
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/inspector/
> remote
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/interpreter
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/jit
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/llint
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/parser
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/profiler
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/runtime
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/tools
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/wasm
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/wasm/js
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/yarr
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/inspector
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/runtime
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/yarr
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/ForwardingHeaders/JavaScriptCore/glib
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/javascriptcoregtk/jsc
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/API/glib
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/javascriptcoregtk
> -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/inspector/
> remote/glib -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/bmalloc
> -I/builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources -I/builddir/build/BUILD/webkitgtk-2.21.92/Source/ThirdParty
> -isystem /usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include 
> -Wno-expansion-to-defined -Wno-noexcept-type -Wno-maybe-uninitialized
> -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute
> -Wformat-security -Wcast-align -Wextra -Wall -O2 -g1 -pipe -Wall
> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
> -fexceptions -fstack-protector-strong -grecord-gcc-switches
> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -march=armv7-a -mfpu=vfpv3-d16
> -mtune=generic-armv7-a -mabi=aapcs-linux -mfloat-abi=hard
> -DUSER_AGENT_GTK_DISTRIBUTOR_NAME='"Fedora"' -fno-strict-aliasing
> -fno-exceptions -fno-rtti -std=c++14 -DNDEBUG -fPIC   -ffp-contract=off -o
> CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-
> sources/UnifiedSource68.cpp.o -c
> /builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/unified-sources/UnifiedSource68.cpp
> In file included from
> /builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap/
> MachineStackMarker.h:24,
>                  from
> /builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap/
> MachineStackMarker.cpp:23,
>                  from
> /builddir/build/BUILD/webkitgtk-2.21.92/armv7hl-redhat-linux-gnueabi/
> DerivedSources/JavaScriptCore/unified-sources/UnifiedSource68.cpp:7:
> /builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap/
> MachineStackMarker.cpp: In function 'int
> JSC::callWithCurrentThreadState(const
> WTF::ScopedLambda<void(JSC::CurrentThreadState&)>&)':
> /builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap/
> MachineStackMarker.cpp:224:46: error: requested alignment is not an integer
> constant
>      DECLARE_AND_COMPUTE_CURRENT_THREAD_STATE(state);
>                                               ^~~~~
> /builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap/
> RegisterState.h:169:77: note: in definition of macro
> 'ALLOCATE_AND_GET_REGISTER_STATE'
>      alignas(std::max(alignof(void*), alignof(RegisterState))) RegisterState
> registers; \
>                                                                             
> ^~~~~~~~~
> /builddir/build/BUILD/webkitgtk-2.21.92/Source/JavaScriptCore/heap/
> MachineStackMarker.cpp:224:5: note: in expansion of macro
> 'DECLARE_AND_COMPUTE_CURRENT_THREAD_STATE'
>      DECLARE_AND_COMPUTE_CURRENT_THREAD_STATE(state);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I temporarily reverted the commit and the build passes.

This is because std::max is not annotated as constexpr in old GCC's libstdc++. (It was a bug since they should be constexpr in C++14).
https://github.com/gcc-mirror/gcc/commit/d3ab86117a4b67ca76491e13e4f705cfb9efb79e
Can you fix it by using `? :` operator instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180829/b012e88e/attachment.html>