[Webkit-unassigned] [Bug 189063] REGRESSION(r235408): GTK bots exiting early

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189063

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REGRESSION(r235407-235410): |REGRESSION(r235408): GTK
                   |GTK bots exiting early      |bots exiting early

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Michael Catanzaro from comment #5)
> (In reply to Simon Fraser (smfr) from comment #3)
> > You're sure it wasn't https://trac.webkit.org/changeset/235399/webkit ?
> 
> Hm, that commit is mighty suspicious, but we do have successful test runs at
> r235402 and r235406, on two different bots. So I don't think so, not unless
> old versions of the test runner are somehow being used by mistake.

I've tested r235406 locally and verified it's good. Tested r235408 and verified it's bad. The only change in r235407 is guarded by PLATFORM(COCOA). So we can pin this on r235408.

The tests are printing on stderr:

FAIL: TestControllerRunLoop timed out.

Looking at the commit, I don't immediately notice anything problematic, so I'll need to attempt to debug why some particular test is stalling.

I did spot one unrelated bug in the commit, in Tools/DumpRenderTree/win/DumpRenderTree.cpp:

    // DumpRenderTree does not support checking for abandonded documents.
    if (!strcmp("#CHECK FOR ABANDONED DOCUMENTS", command)) {

I noticed that "abandonded" was misspelled. Then I noticed that the command here is different than everywhere else. Should probably be:

    // DumpRenderTree does not support checking for world leaks.
    if (!strcmp("#CHECK FOR WORLD LEAKS", command)) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180829/8461cf6f/attachment-0001.html>