[Webkit-unassigned] [Bug 171100] Implement the Web Share API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171100

--- Comment #58 from Tim Horton <thorton at apple.com> ---
Comment on attachment 348299
  --> https://bugs.webkit.org/attachment.cgi?id=348299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348299&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:423
> + at property (nonatomic, copy, nullable, setter=_setTitle:) NSString *_title;

Get that `nullable` out of there, it's viral and makes the compiler want more nullable in more places.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:385
> +- (void)invokeShareSheetWithResolution:(BOOL)resolved WK_API_AVAILABLE(ios(WK_IOS_TBA));

I see other things around here don't have leading underscores, but I don't understand it. Wenson, what's up with that?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:67
> +struct ShareDataWithParsedURL;

Sort this up one line.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6074
> +void WebPage::runShareSheet(ShareDataWithParsedURL& shareData, WTF::CompletionHandler<void(bool)>&& callback)

"Run" is weird. How about s/runShareSheet/showShareSheet/.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6085
> +void WebPage::runShareSheetResponse(bool wasGranted, ShareSheetCallbackID callbackID)

"Run" is weird. How about s/runShareSheetResponse/didCompleteShareSheet/ or didDismissShareSheet or something

> LayoutTests/resources/ui-helper.js:268
> +	const resolveShareSheet = `(() => uiController.invokeShareSheetWithResolution(${resolved}))()`;
> +	return new Promise(resolve => testRunner.runUIScript(resolveShareSheet, resolve));

The confusion here between you and Wenson is that you have TABS here. No tabs please (and this is why!!)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180828/3c55aa0c/attachment.html>