[Webkit-unassigned] [Bug 188978] [WinCairo] Add CryptoDigiestOpenSSL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188978

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348235|review?                     |review-
              Flags|                            |

--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348235
  --> https://bugs.webkit.org/attachment.cgi?id=348235
Patch take2

View in context: https://bugs.webkit.org/attachment.cgi?id=348235&action=review

> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:81
> +    case CryptoDigest::Algorithm::SHA_1:
> +        delete toSHA1Context(m_context.get());
> +        return;
> +    case CryptoDigest::Algorithm::SHA_224:
> +        delete toSHA224Context(m_context.get());
> +        return;

This is what a virtual destructor is for.

> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:96
> +    std::unique_ptr<CryptoDigest> digest(new CryptoDigest);

This is also what make_unique is for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180828/aff72193/attachment.html>