[Webkit-unassigned] [Bug 171100] Implement the Web Share API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 20:12:49 PDT 2018


--- Comment #54 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 348241
  --> https://bugs.webkit.org/attachment.cgi?id=348241

View in context: https://bugs.webkit.org/attachment.cgi?id=348241&action=review

>> Source/WebKit/UIProcess/WebPageProxy.cpp:4593
>> +    CompletionHandler<void(bool)> completionHandler = [this, protectedThis = makeRef(*this), callbackID] (bool access) {
> I don't think you need to capture this as well as protectedThis; you can just capture protectedThis and then use protectedThis->m_process and protectedThis->m_pageID.

Actually, never mind! A quick grep through WebKit shows that this is a pretty common idiom.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180828/4533f8df/attachment.html>

More information about the webkit-unassigned mailing list