[Webkit-unassigned] [Bug 171100] Implement the Web Share API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171100

--- Comment #49 from Olivia Barnett <obarnett at apple.com> ---
(In reply to Wenson Hsieh from comment #48)
> Comment on attachment 348225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348225&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        No new tests; adjusted expectations for existing tests.
> 
> You should mention your new test in fast/events/ios!
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:384
> > +- (void)invokeShareSheetWithResolution:(BOOL)resolved WK_API_AVAILABLE(ios(11.3));
> 
> This should be WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> > Source/WebKit/UIProcess/PageClient.h:205
> > +    virtual bool showShareSheet(WebPageProxy*, const WebCore::ShareDataWithParsedURL&,  WTF::CompletionHandler<void (bool)>&&) { return false; }
> 
> Nit - extra space before WTF::
> 
> > Source/WebKit/UIProcess/WebPageProxy.cpp:5254
> > +    
> 
> Nit - it doesn't look like this extra whitespace change is intended
> 
> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.h:46
> > + at property (nonatomic, weak, assign) id <WKShareSheetDelegate> delegate;
> 
> Nit - I don't think you need the assign here.
> 
> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:40
> > + at interface _WKShareSheetItem : NSObject
> 
> Hm...what's _WKShareSheetItem used for?

Ah, nothing.
> 
> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:80
> > +    RetainPtr<UIActivityViewController> shareSheetController = adoptNS([[UIActivityViewController alloc] initWithActivityItems:shareDataArray.get() applicationActivities:nil]);
> 
> Nit - s/RetainPtr<UIActivityViewController>/auto/
> 
> > Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:88
> > +    _shareSheetViewController = shareSheetController;
> 
> This can be _shareSheetViewController = WTFMove(shareSheetController);
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:6085
> > +void WebPage::runShareSheetResponse(bool wasGranted, uint64_t callbackID)
> 
> s/uint64_t/ShareSheetCallbackID/ here?
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.h:1734
> > +    HashMap<uint64_t, WTF::Function<void(bool completed)>> m_shareSheetResponseCallbackMap;
> 
> ShareSheetCallbackID here too?
> 
> > LayoutTests/fast/events/ios/share.html:20
> > +                    navigator.share({ title: "Example Page", url: "url", text: "text"}).then((result) => {
> 
> Nit - Indentation is a bit off here too.
> 
> Also, a space between "text" and }
> 
> > LayoutTests/resources/ui-helper.js:248
> > +	const resolveShareSheet = `(() => uiController.invokeShareSheetWithResolution(${resolved}))()`;
> 
> Nit - Indentation is a bit off here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180827/130c05a3/attachment-0001.html>