[Webkit-unassigned] [Bug 186714] [Datalist][iOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186714

--- Comment #12 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Wenson Hsieh from comment #10)
> Comment on attachment 348056 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=348056&action=review
> 
> > Source/WebCore/html/TextFieldInputType.cpp:879
> > +    userActivated |= (type == DataListSuggestionActivationType::TextChanged);
> 
> Not sure I'd name this "userActivated", since we poke a hole in that
> constraint on iOS if type == DataListSuggestionActivationType::TextChanged.
> Maybe "shouldDisplaySuggestions"?
> 
> It also seems weird that we relax this constraint only for iOS. Is there a
> reason we need to gate this on user gesture more strictly for macOS, or can
> we remove this platform check?
> 

UserGestureIndicator::processingUserGesture() has a different behavior on iOS and macOS when typing. By the time this method is called, processingUserGesture returns false on iOS. 

However, I can remove the platform check, since TextChanged is only used through TextFieldInputType::didSetValueByUserEdit. This means that the "user activated" behavior of displaying the suggestions is preserved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180827/e3f05b28/attachment.html>