[Webkit-unassigned] [Bug 188978] [WinCairo] Add CryptoDigiestOpenSSL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188978

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 348128
  --> https://bugs.webkit.org/attachment.cgi?id=348128
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348128&action=review

>> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:38
>> +#ifndef OPENSSL_NO_SHA1
> 
> What are the cases where this and the other macros would be defined?

Do we want to support those cases?  I think probably not, especially not without a fallback.

> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:71
> +    : m_context(new CryptoDigestContext)

This is what std::make_unique is for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180827/b52d904b/attachment-0001.html>