[Webkit-unassigned] [Bug 188978] [WinCairo] Add CryptoDigiestOpenSSL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188978

--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 348128
  --> https://bugs.webkit.org/attachment.cgi?id=348128
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348128&action=review

LGTM and adding tests is awesome.

I'm just not sure we need all the #ifndef's hanging out.

> Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp:38
> +#ifndef OPENSSL_NO_SHA1

What are the cases where this and the other macros would be defined?

> Tools/TestWebKitAPI/PlatformWin.cmake:129
> +if (PAL_LIBRARY_TYPE MATCHES STATIC)

Could this go into the root CMakelists.txt?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180827/0ff2685f/attachment.html>