[Webkit-unassigned] [Bug 156674] Build tools should work when the /usr/bin/python is python3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 09:57:49 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=156674

--- Comment #17 from Konstantin Tokarev <annulen at yandex.ru> ---
IMO, this patch is hard to review because it's not clear where files are moved verbatimly and where they are modified. If there are any changes in moved files, it would be better to split patch in two parts: move stuff verbatimly, and then apply modifications.

(There are review systems which are able to track file renames and visualize modifications appropriately; unfortunately our tooling is inferior)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180827/ec49d6b4/attachment.html>


More information about the webkit-unassigned mailing list