[Webkit-unassigned] [Bug 188893] REGRESSION(r234879): Hundreds of layout tests are timing out in WinCairo Debug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188893

--- Comment #9 from Fujii Hironori <Hironori.Fujii at sony.com> ---
I compared disassembled code of GenericHashTraits<Color>::constructEmptyValue of built by msbuild and Ninja.

>	WebKit.dll!WTF::GenericHashTraits<WebCore::Color>::constructEmptyValue<WTF::HashTraits<WebCore::Color> >(WebCore::Color & slot) Line 76	C++

MSBuild:

> --- c:\webkit\ga\webkitbuild\debug\derivedsources\forwardingheaders\wtf\hashtraits.h 
> 
>     template <typename Traits>
>     static void constructEmptyValue(T& slot)
>     {
> 00007FFB1F07DE80  mov         qword ptr [rsp+8],rcx  
> 00007FFB1F07DE85  push        rdi  
> 00007FFB1F07DE86  sub         rsp,30h  
> 00007FFB1F07DE8A  mov         rdi,rsp  
> 00007FFB1F07DE8D  mov         ecx,0Ch  
> 00007FFB1F07DE92  mov         eax,0CCCCCCCCh  
> 00007FFB1F07DE97  rep stos    dword ptr [rdi]  
> 00007FFB1F07DE99  mov         rcx,qword ptr [slot]  
>         new (NotNull, std::addressof(slot)) T(Traits::emptyValue());
> 00007FFB1F07DE9E  mov         rcx,qword ptr [slot]  
> 00007FFB1F07DEA3  call        std::addressof<WebCore::Color> (07FFB1F07C650h)  
> 00007FFB1F07DEA8  mov         r8,rax  
> 00007FFB1F07DEAB  xor         edx,edx  
> 00007FFB1F07DEAD  mov         ecx,8  
> 00007FFB1F07DEB2  call        WebCore::Color::operator new (07FFB1F08EF40h)  
> 00007FFB1F07DEB7  mov         qword ptr [rsp+20h],rax  
> 00007FFB1F07DEBC  cmp         qword ptr [rsp+20h],0  
> 00007FFB1F07DEC2  je          WTF::GenericHashTraits<WebCore::Color>::constructEmptyValue<WTF::HashTraits<WebCore::Color> >+55h (07FFB1F07DED5h)  
> 00007FFB1F07DEC4  mov         rcx,qword ptr [rsp+20h]  
> 00007FFB1F07DEC9  call        WTF::GenericHashTraits<WebCore::Color>::emptyValue (07FFB1F09BDE0h)  
> 00007FFB1F07DECE  mov         qword ptr [rsp+28h],rax  
> 00007FFB1F07DED3  jmp         WTF::GenericHashTraits<WebCore::Color>::constructEmptyValue<WTF::HashTraits<WebCore::Color> >+5Eh (07FFB1F07DEDEh)  
> 00007FFB1F07DED5  mov         qword ptr [rsp+28h],0  
>     }
> 00007FFB1F07DEDE  add         rsp,30h  
> 00007FFB1F07DEE2  pop         rdi  
> 00007FFB1F07DEE3  ret  


Ninja

> --- c:\webkit\gb\webkitbuild\debug\derivedsources\forwardingheaders\wtf\hashtraits.h 
> 
>     template <typename Traits>
>     static void constructEmptyValue(T& slot)
>     {
> 00007FFB1F338830  mov         qword ptr [rsp+8],rcx  
> 00007FFB1F338835  push        rdi  
> 00007FFB1F338836  sub         rsp,30h  
> 00007FFB1F33883A  mov         rdi,rsp  
> 00007FFB1F33883D  mov         ecx,0Ch  
> 00007FFB1F338842  mov         eax,0CCCCCCCCh  
> 00007FFB1F338847  rep stos    dword ptr [rdi]  
> 00007FFB1F338849  mov         rcx,qword ptr [slot]  
>         new (NotNull, std::addressof(slot)) T(Traits::emptyValue());
> 00007FFB1F33884E  mov         rcx,qword ptr [slot]  
> 00007FFB1F338853  call        std::addressof<WebCore::Color> (07FFB1F3360C0h)  
> 00007FFB1F338858  mov         r8,rax  
> 00007FFB1F33885B  xor         edx,edx  
> 00007FFB1F33885D  mov         ecx,8  
> 00007FFB1F338862  call        WebCore::Color::operator new (07FFB1F3410F0h)  
> 00007FFB1F338867  mov         qword ptr [rsp+20h],rax  
> 00007FFB1F33886C  cmp         qword ptr [rsp+20h],0  
> 00007FFB1F338872  je          WTF::GenericHashTraits<WebCore::Color>::constructEmptyValue<WTF::HashTraits<WebCore::Color> >+55h (07FFB1F338885h)  
> 00007FFB1F338874  mov         rcx,qword ptr [rsp+20h]  
> 00007FFB1F338879  call        WTF::HashTraits<WebCore::Color>::emptyValue (07FFB1F34A7D0h)  
> 00007FFB1F33887E  mov         qword ptr [rsp+28h],rax  
> 00007FFB1F338883  jmp         WTF::GenericHashTraits<WebCore::Color>::constructEmptyValue<WTF::HashTraits<WebCore::Color> >+5Eh (07FFB1F33888Eh)  
> 00007FFB1F338885  mov         qword ptr [rsp+28h],0  
>     }
> 00007FFB1F33888E  add         rsp,30h  
> 00007FFB1F338892  pop         rdi  
> 00007FFB1F338893  ret  

WTF::GenericHashTraits<WebCore::Color>::emptyValue is called in one built by MSBuild.
But, WTF::HashTraits<WebCore::Color>::emptyValue is called in one built by Ninja.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180827/d3f08a2b/attachment.html>