[Webkit-unassigned] [Bug 171100] Implement the Web Share API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171100

--- Comment #31 from Tim Horton <thorton at apple.com> ---
Comment on attachment 348062
  --> https://bugs.webkit.org/attachment.cgi?id=348062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348062&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).

You can totally change this to "No new tests; adjusted expectations for existing tests." and get rid of the OOPS and be happy.

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:433
> + at property (nonatomic, retain, setter=_setContainerViews:)
> +NSArray *_containerViews;

What happened here?

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:34
> +#import "APIArray.h"
> +#import "APIData.h"
> +#import "APIOpenPanelParameters.h"
> +#import "APIString.h"

I doubt you need these.

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:40
> +#import "WKData.h"
> +#import "WKStringCF.h"
> +#import "WKURLCF.h"
> +#import "WebIconUtilities.h"

I doubt you need these.

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:42
> +#import <MobileCoreServices/MobileCoreServices.h>

I doubt you need this.

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:43
> +#import <WebCore/LocalizedStrings.h>

I doubt you need this.

> LayoutTests/imported/w3c/web-platform-tests/web-share/idlharness.https-expected.txt:3
> -FAIL Navigator interface: operation share(ShareData) assert_own_property: interface prototype object missing non-static operation expected property "share" missing
> +FAIL Navigator interface: operation share(ShareData) assert_equals: property has wrong .length expected 0 but got 1

Need to ask Sam about this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180825/39ae056a/attachment.html>