[Webkit-unassigned] [Bug 186714] [Datalist][iOS] Add suggestions UI for TextFieldInputTypes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 24 14:02:16 PDT 2018


--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 347869
  --> https://bugs.webkit.org/attachment.cgi?id=347869

View in context: https://bugs.webkit.org/attachment.cgi?id=347869&action=review

> Source/WebKit/ChangeLog:8
> +        On iOS, we have less space display suggestions from a datalist element compared to

Nit - less space to display

> Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm:94
> +WebDataListSuggestionsDropdownIOS::~WebDataListSuggestionsDropdownIOS() { }

Nit - do you need this destructor, or can you omit it/use = default?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180824/ddd1c6d5/attachment.html>

More information about the webkit-unassigned mailing list