[Webkit-unassigned] [Bug 171100] Implement the Web Share API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171100

--- Comment #23 from Tim Horton <thorton at apple.com> ---
Comment on attachment 348022
  --> https://bugs.webkit.org/attachment.cgi?id=348022
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348022&action=review

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.h:45
> + at property (nonatomic, assign) id <WKShareSheetDelegate> delegate;

This should be weak.

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:35
> +#import "UIKitSPI.h"

LOL, _title is only in  the WebCore UIKitSPI.h, not the one you included here. So sorry :( I think you'll need to add _title to the WebKit one. (you can grab those five lines from the WebCore one).

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:74
> +    bool arrayContainsElements = false;

Why this instead of just testing [shareDataArray count]? (Either way is fine I guess)

> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:137
> +    // May need to clear/dismiss VC?

Get rid of this comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180824/17e3b307/attachment.html>