[Webkit-unassigned] [Bug 188746] [GTK] Touchscreen pinch to zoom should scale the page like other platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188746

--- Comment #40 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347921
  --> https://bugs.webkit.org/attachment.cgi?id=347921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347921&action=review

What does the Epiphany patch look like now? Epiphany has to call webkit_web_view_reset_page_scale() when modifying the zoom?

Is there any time a browser would want to use this API *except* when modifying the zoom? If so, r=me. If not, then WebKit should probably just reset the scale itself when the zoom changes, like you had proposed earlier?

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:3160
> + * Resets the page scale of @web_view, i.e. the factor by
> + * which the page is magnified without changing the layout

OH. So the difference between scale and zoom is that zoom changes the layout?

I finally understand!

P.S. add a period at the end of this sentence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180823/15134010/attachment.html>