[Webkit-unassigned] [Bug 183621] Add support for the `inputmode` attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183621

--- Comment #15 from Daniel Bates <dbates at webkit.org> ---
(In reply to Daniel Bates from comment #13)
> > Source/WebCore/html/HTMLTextAreaElement.idl:62
> > +    attribute DOMString inputMode;
> 
> As per
> <https://html.spec.whatwg.org/multipage/interaction.html#dom-inputmode> this
> should be a reflected attribute. Please add "[Reflect]" before "attribute".
> 

Disregard this remark. Our binding generator code does not support reflections with a custom getter.

> [...]
> 
> > Source/WebCore/html/HTMLTextFormControlElement.cpp:702
> > +void HTMLTextFormControlElement::setInputMode(const String& value)
> > +{
> > +    setAttributeWithoutSynchronization(inputmodeAttr, value);
> > +}
> 
> This function is unnecessary when the attribute is marked "[Reflect]" in the
> IDL.


Disregard this remark.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180822/b6f49141/attachment.html>