[Webkit-unassigned] [Bug 188843] NetworkCache::Storage::lastStableVersion should be a developer-only feature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 13:34:11 PDT 2018


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |dbates at webkit.org

--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 347792
  --> https://bugs.webkit.org/attachment.cgi?id=347792

View in context: https://bugs.webkit.org/attachment.cgi?id=347792&action=review

> Source/WebKit/Shared/mac/ChildProcessMac.mm:740
> +    static bool isSystemWebKit = [] {
> +        return [[webKit2Bundle() bundlePath] hasPrefix:@"/System/"];
> +    }();

This will treat an installed development WebKit root or Xcode installed development WebKit as a system install. Is this OK? Otherwise, we should make use of the codesign framework API/SPI to actually check that the process is "restricted" and/or signed by Apple.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180822/0cf324ac/attachment.html>

More information about the webkit-unassigned mailing list