[Webkit-unassigned] [Bug 188746] [GTK] Touchscreen pinch to zoom should scale the page like other platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 23:55:31 PDT 2018


--- Comment #31 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 347699
  --> https://bugs.webkit.org/attachment.cgi?id=347699

View in context: https://bugs.webkit.org/attachment.cgi?id=347699&action=review

> Source/WebKit/ChangeLog:7
> +

Please, explain the changes here.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:-1127
> -        m_webView->priv->pageClient->zoom(scale);

I think this is the only user of PageClientImpl::zoom() so it can be removed.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1131
> +        FloatPoint scaledZoomCenter = FloatPoint(initialPoint);

FloatPoint scaledZoomCenter(initialPoint);

> Source/WebKit/UIProcess/gtk/GestureController.cpp:206
> -    m_client.zoom(m_scale);
> +    m_client.zoom(m_scale, m_initialPoint, m_viewPoint);

I wonder if, instead of passing both values to the client and let them compute the center in page coordinates, we could do the conversion here and pass only the center to the client that would only need to call WebPageProxy::scalePage(scale, center);

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180822/f961f5fe/attachment.html>

More information about the webkit-unassigned mailing list