[Webkit-unassigned] [Bug 188746] [GTK] Touchscreen pinch to zoom should scale the page like other platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 17:01:31 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=154963

--- Comment #23 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Justin Michaud from comment #22)
> It seems this patch also fixes this bug:
> https://bugs.webkit.org/show_bug.cgi?id=154963
> I fixed the Canadian-ism for center. For the second comment,
> webkitWebViewBaseGetPage is also used by the previous function, so I am
> wondering if I should change both, or leave it as-is.

Hm yes, I would, while you're at it, since you changed a line just below it. That's the only place in this file where it's used. Of course it makes no real difference, but our style is to access the priv variable directly when there's no difference.

> For non touchscreen zooming, it works but the two zooms are independent. I
> wonder if this is a change that should be made in epiphany (to reset the
> page scaling when you press ctrl + [0-+]), or if we should reset the page
> scale when you set the zoom. In the first case, I think a getter / setter
> would need to be added to the public api. What do you think?

OK, it sounds like this is the last bit that needs to be worked out.

I'm confused why scale and zoom are different concepts in the first place. By far the simplest solution is to have just one zoom that changes when you pinch. It would be unfortunate if we have to expose a second setting for scale.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180822/9304754e/attachment-0001.html>

More information about the webkit-unassigned mailing list