[Webkit-unassigned] [Bug 171100] Implement the Web Share API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 14:35:49 PDT 2018


--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347690
  --> https://bugs.webkit.org/attachment.cgi?id=347690

View in context: https://bugs.webkit.org/attachment.cgi?id=347690&action=review

Not a full review.

> Source/WebCore/page/Navigator.cpp:102
> +    if (m_frame->page()) {

Use an early return to avoid indenting all the rest of the code.

> Source/WebCore/page/Navigator.cpp:110
> +        if (!url.isValid())
> +            promise->reject(TypeError);

You should return here, right?

> Source/WebCore/page/Navigator.cpp:123
> +            return;

No need for the return.

> Source/WebKit/Shared/WebPreferences.yaml:763
> +  humanReadableName: "Web share"

Can someone read this and figure out what the feature is about?

> Source/WebKit/Shared/WebPreferences.yaml:764
> +  humanReadableDescription: "Web share API"

Web Share API?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/fe37e501/attachment.html>

More information about the webkit-unassigned mailing list