[Webkit-unassigned] [Bug 188772] Allow override of viewport configuration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188772

--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347590
  --> https://bugs.webkit.org/attachment.cgi?id=347590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347590&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:785
> +#if PLATFORM(IOS)

We don't like the #ifdefs. Maybe just leave this stuff on for all platforms; it will just be a no-op on macOS.

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:146
> -#if !TARGET_OS_IPHONE
> +#if TARGET_OS_IPHONE
> + at property (nonatomic, setter=_setShouldIgnoreMetaViewport:) BOOL _shouldIgnoreMetaViewport WK_API_AVAILABLE(ios(WK_IOS_TBA));
> +#else

We don't like the #ifdefs. Maybe just leave this stuff on for all platforms; it will just be a no-op on macOS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/98d51e21/attachment.html>