[Webkit-unassigned] [Bug 188746] [GTK] Touchscreen pinch to zoom should scale the page like other platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 09:27:27 PDT 2018


--- Comment #16 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347640
  --> https://bugs.webkit.org/attachment.cgi?id=347640

View in context: https://bugs.webkit.org/attachment.cgi?id=347640&action=review

Well the code changes, at least, are way simpler now. That looks good.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1128
> +        auto* page = webkitWebViewBaseGetPage(m_webView);

Instead of webkitWebViewBaseGetPage(), just use webView->priv->pageProxy directly.

> Source/WebKit/UIProcess/gtk/GestureController.h:54
> +    virtual void zoom(double scale, const WebCore::IntPoint& initialPoint, const WebCore::IntPoint& centre) = 0;

center here, too

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/0f18efbd/attachment.html>

More information about the webkit-unassigned mailing list