[Webkit-unassigned] [Bug 186714] [Datalist][iOS] Add suggestions UI for TextFieldInputTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=186714

--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347585
  --> https://bugs.webkit.org/attachment.cgi?id=347585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347585&action=review

> Source/WebCore/html/TextFieldInputType.cpp:880
> +#if !PLATFORM(IOS)
>      if (!UserGestureIndicator::processingUserGesture())
>          return;
> +#endif

Why is this OK? It seems really odd for a user gesture check to not apply to iOS. Possible that instead you want to fake a user gesture in some particular case where you know it’s OK?

> Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm:45
> + at interface WKFormInputSession ()
> +- (void)setCustomInputView:(UIView *)customInputView;
> +- (void)setSuggestions:(NSArray<UITextSuggestion *> *)suggestions;
> + at end

Why not... somewhere else? All of these things are internal, aren’t they?

> Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm:49
> + at interface WKContentView ()
> +- (WKFormInputSession *)_formInputSession;
> + at end

Why not in WKContentView(Interaction).h?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/f52cf50c/attachment.html>