[Webkit-unassigned] [Bug 186714] [Datalist][iOS] Add suggestions UI for TextFieldInputTypes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 17:48:05 PDT 2018


--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347585
  --> https://bugs.webkit.org/attachment.cgi?id=347585

View in context: https://bugs.webkit.org/attachment.cgi?id=347585&action=review

> Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm:369
> +    [cell.textLabel setLineBreakMode:NSLineBreakByTruncatingTail];

Any reason you're not sticking with dot syntax past the first property?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:390
> +        && ![suggestions.firstObject isKindOfClass:NSClassFromString(@"WKDataListTextSuggestion")]) {

isKindOfClass for our own class like this is not a great smell

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1005
>          [_inputPeripheral endEditing];
> +        if ([[_formInputSession customInputView] respondsToSelector:@selector(endEditing)])
> +            [[_formInputSession customInputView] performSelector:@selector(endEditing)];
> +

Wonder if we should put these somewhere together. There are already two callers, which might be enough.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180821/53730ef3/attachment.html>

More information about the webkit-unassigned mailing list