[Webkit-unassigned] [Bug 171100] Implement the Web Share API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 20 14:38:42 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=171100
--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347525
--> https://bugs.webkit.org/attachment.cgi?id=347525
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=347525&action=review
> Source/WebKit/UIProcess/WebShareSheetResultListenerProxy.cp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.
Get rid of this file. Also, it's 2018
> Source/WebKit/UIProcess/ios/forms/WKShareSheet.h:52
> +- (void)presentWithParameters:(NSArray*)parameters resultListener:(WebKit::WebShareSheetResultListenerProxy*)listener completionHandler:(WTF::CompletionHandler<void(bool)>&&)completionHandler;
ObjC stars go on the right (NSArray *). The C++ one is right.
> Source/WebKit/UIProcess/ios/forms/WKShareSheet.mm:94
> +- (void)presentWithParameters:(NSArray*)parameters resultListener:(WebKit::WebShareSheetResultListenerProxy*)listener completionHandler:(WTF::CompletionHandler<void(bool)>&&)completionHandler
You don't need WebShareSheetResultListener. Get rid of it everywhere. You just use the completion block mechanism instead, and don't have any API.
> Source/WebKit/WebProcess/WebPage/WebPage.h:1576
> + RefPtr<WebShareSheetResultListener> m_activeShareSheetResultListener;
You don't need WebShareSheetResultListener
> Source/WebKit/WebProcess/WebPage/WebPage.h:1740
> + HashMap<uint64_t, WTF::Function<void(bool granted)>> m_shareSheetResponseCallbackMap;
I don't think "granted" is the right word.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180820/579339e3/attachment-0001.html>
More information about the webkit-unassigned
mailing list