[Webkit-unassigned] [Bug 171656] Throw an exception if window.open() gets passed a URL that cannot be parsed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 19 16:28:10 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=171656

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #347463|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 347463
  --> https://bugs.webkit.org/attachment.cgi?id=347463
Patch

Looks fine. Idiom for returning nullptr in such cases is pretty ugly.

For website programmers who did this by accident, it seems the exception is not as clear as the wording of the console message was.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180819/200b65af/attachment.html>


More information about the webkit-unassigned mailing list