[Webkit-unassigned] [Bug 188718] New: run-webkit-tests triggers a python error if building DumpRenderTree produces non-ASCII output

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188718

            Bug ID: 188718
           Summary: run-webkit-tests triggers a python error if building
                    DumpRenderTree produces non-ASCII output
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: simon.fraser at apple.com
                CC: lforschler at apple.com

If I make a change to DumpRenderTree that fails to compile, and have an iPhone plugged into my computer, xcodebuild can dump non-ASCII stuff like "2018-08-17 20:55:52.550 xcodebuild[30152:213122]  iPhoneConnect: 📱<TheX, iPhone, 12.0..." and then webkitpy fails trying to show that:

UnicodeEncodeError raised: 'ascii' codec can't encode character u'\u2019' in position 1694: ordinal not in range(128)
Traceback (most recent call last):
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 85, in main
    run_details = run(port, options, args, stderr)
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 449, in run
    run_details = manager.run(args)
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 246, in run
    if not self._set_up_run(tests_to_run):
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 164, in _set_up_run
    if not self._port.check_build():
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 230, in check_build
    if not self._root_was_set and self.get_option('build') and not self._build_driver():
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 1500, in _build_driver
    _log.error(e.message_with_output(output_limit=None))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1191, in error
    self._log(ERROR, msg, args, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1284, in _log
    self.handle(record)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1294, in handle
    self.callHandlers(record)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 1334, in callHandlers
    hdlr.handle(record)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/logging/__init__.py", line 757, in handle
    self.emit(record)
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py", line 142, in emit
    self._meter.writeln(record.getMessage(), record.created, record.process)
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py", line 118, in writeln
    self.write(self._ensure_newline(txt), now, pid)
  File "/Volumes/Data/Development/apple/webkit/OpenSource/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py", line 111, in write
    msg = '{}{}'.format(timestamp_string, txt)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 1694: ordinal not in range(128)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180818/36fe342f/attachment-0001.html>