[Webkit-unassigned] [Bug 188695] [GLIB] Complete the JSCException API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 07:26:53 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |mcatanzaro at igalia.com
 Attachment #347358|review?                     |review+
              Flags|                            |

--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347358
  --> https://bugs.webkit.org/attachment.cgi?id=347358

View in context: https://bugs.webkit.org/attachment.cgi?id=347358&action=review

> Source/JavaScriptCore/API/glib/JSCException.cpp:269
> +const char* jsc_exception_get_backtrace_string(JSCException* exception)

Hm, shouldn't it use const gchar*, for consistency with our other public APIs? I know gchar/gint/etc. are dumb types, but consistency is good. Maybe you should audit the entire JSC API for this. We definitely use the g types in the WebKit2 API, for example.

> Source/JavaScriptCore/API/glib/JSCException.cpp:286
> + * Get the string representation of @exception error.
> + *
> + * Returns: (transfer full): the string representation of @exception error.

It reads better without the word "error" at the end.

"Get the string representation of @exception.

Returns: (transfer full): the string representation of @exception."

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180817/dfda5ddc/attachment.html>

More information about the webkit-unassigned mailing list