[Webkit-unassigned] [Bug 188696] beforeunload interoperability issues with a throwing return

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 06:48:58 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=188696

--- Comment #1 from PhistucK <phistuck at chromium.org> ---
I think the problem is either that convert<IDLNullable<IDLDOMString>>(*exec, retval)) is called but nothing checks whether it threw an exception in order to stop the execution, or that the conversion that convert<...> employs does not use toStringOrNull and so it gets the empty string instead of null when it fails.
handleBeforeUnloadEventReturnValue only checks -
if (returnValue.isNull())
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/bindings/js/JSEventListener.cpp#L91
And preventDefault() otherwise.

Or maybe both.

Maybe the fix is a simple -
if (returnValue.isNull() || returnValue.isEmpty())

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180817/1916f090/attachment.html>


More information about the webkit-unassigned mailing list