[Webkit-unassigned] [Bug 188695] [GLIB] Complete the JSCException API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 04:48:08 PDT 2018


Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |aperez at igalia.com

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 347356
  --> https://bugs.webkit.org/attachment.cgi?id=347356

View in context: https://bugs.webkit.org/attachment.cgi?id=347356&action=review

Looks good to me overall, but please check the comment about using
“backtrace” instead of “back trace” before landing.

> Source/JavaScriptCore/API/glib/JSCException.cpp:262
> + * jsc_exception_get_back_trace_string:

Somehow this function name feels a bit clunky when reading it, because
usually “backtrace” is how the term is written. For the sake of double
checking, I did the following:

    % rg -i backtrace /usr/include/|wc -l
    % rg -i back_trace /usr/include/ | wc -l

I am *very* sure that we want this to be “jsc_exception_get_backtrace_string”.

> Source/JavaScriptCore/API/glib/JSCException.cpp:265
> + * Get a string with the exception back trace.

Let's also use “backtrace” in documentation comments, please.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180817/3ef66094/attachment.html>

More information about the webkit-unassigned mailing list